Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Set range of node version in package.json #1178

Merged
merged 1 commit into from
May 20, 2023
Merged

🔧 Set range of node version in package.json #1178

merged 1 commit into from
May 20, 2023

Conversation

baifengheixi
Copy link
Contributor

@baifengheixi baifengheixi commented May 10, 2023

baifengheixi Quick baifengheixi /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Powered by Pull Request Badge

Category:

One of: Bugfix

Overview

Update nodejs version section in package.json file

Issue Number #1159

New Vars

Update nodejs version section in package.json file to less than 18.0.0 to fix deploy error

Screenshot
Screenshot 2023-05-10 143017

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/645bf799b04ae3122cad81b2
😎 Deploy Preview https://deploy-preview-1178--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented May 10, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@baifengheixi baifengheixi changed the title Update package.json (#1) 🔧 Update node version in package.json May 10, 2023
@gitguardian
Copy link

gitguardian bot commented May 10, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@darkone23
Copy link

darkone23 commented May 12, 2023

This dependency issue is transitive through the vue-cli-tools.

You can run yarn why @achrinza/node-ipc

The docker container runs node 16. I do not think dashy supports node 18.

@baifengheixi
Copy link
Contributor Author

This dependency issue is transitive through the vue-cli-tools.

You can run yarn why @achrinza/node-ipc

The docker container runs node 16. I do not think dashy supports node 18.

Than I set node less than version 18.0.0

@baifengheixi baifengheixi changed the title 🔧 Update node version in package.json 🔧 Set range of node version in package.json May 12, 2023
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lissy93 Lissy93 merged commit 79bbc37 into Lissy93:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants