Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Rename pre-build to pre_build #131

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

evroon
Copy link
Contributor

@evroon evroon commented Aug 7, 2021

Quick evroon /feature-arm-docker → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 evroon Powered by Pull Request Badge

Category:
Bugfix for ARM build hook for DH builds.

Overview
Fix for PR #130

Issue Number #117

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added

@evroon evroon requested a review from Lissy93 as a code owner August 7, 2021 15:27
@netlify
Copy link

netlify bot commented Aug 7, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 87f3d39

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/610ea66ab10d8600070d2726

😎 Browse the preview: https://deploy-preview-131--dashy-dev.netlify.app

@evroon evroon changed the title Rename pre-build to pre_build [FIX] Rename pre-build to pre_build Aug 7, 2021
@Lissy93 Lissy93 merged commit e89ee82 into Lissy93:master Aug 7, 2021
@evroon evroon deleted the feature-arm-docker branch August 7, 2021 15:33
@evroon
Copy link
Contributor Author

evroon commented Aug 7, 2021

Ah is it still failing with the same error?

@Lissy93
Copy link
Owner

Lissy93 commented Aug 7, 2021

Yup, it is :/ I'm going to make a GH action, which should hopefully work. 🤞
I'll let you know when it's done, and thanks so much for all your help :)

@Lissy93
Copy link
Owner

Lissy93 commented Aug 7, 2021

Oh wait- the arm32v7 build is working!!!!!!!
That's awesome! Thanks so much for that 😇
I will look into the arm64v8 build

@evroon
Copy link
Contributor Author

evroon commented Aug 7, 2021

Cool!
The docker image is indeed working nicely on my rpi4.

There seems something wrong with the arm64v8/alpine image, I can't build Dockerfile-arm64v8, it gives:
standard_init_linux.go:211: exec user process caused "no such file or directory" at the first RUN line, whatever command you give it.

asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#131

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants