Fix Vue's PWA manifestCrossorigin, remove second mainfest from head #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👷 Deploy Preview for dashy-dev processing.
|
|
Changes preview: Legend: |
Lissy93
approved these changes
Oct 11, 2023
|
The fix for this issue has now been released in 2.1.2 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bugfix
Overview
Fixed PWA manifest crossorigin, required for PWA behind auth proxy. Removed manually added manifest duplicate as redundant, Vue already added it's own.
https://cli.vuejs.org/core-plugins/pwa.html#configuration
Issue Number #1219
Code Quality Checklist