Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.md #1364

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Update deployment.md #1364

merged 1 commit into from
Oct 26, 2023

Conversation

Glitch3dPenguin
Copy link
Contributor

@Glitch3dPenguin Glitch3dPenguin commented Oct 26, 2023

Glitch3dPenguin Quick Glitch3dPenguin /patch-1 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: -13 Label Unchecked Tasks Powered by Pull Request Badge

Remove the option to deploy to CF workers. CF Workers and Pages have changed dramatically over the past 2 years and this feature is no longer compatible. With over a year of this being an issue it doesn't seem like anyone in the community wants to get it working so let's remove the option so issues related to CF Deploy can be closed. It's not an ideal way to deploy this anyway.

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Overview

Briefly outline your new changes...

Issue Number (if applicable) #00

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Remove the option to deploy to CF workers. CF Workers and Pages have changed dramatically over the past 2 years and this feature is no longer compatible.
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:09pm

@netlify
Copy link

netlify bot commented Oct 26, 2023

👷 Deploy Preview for dashy-dev processing.

Name Link
🔨 Latest commit 9b570fa
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/653a8eefd368000008e598a1

@viezly
Copy link

viezly bot commented Oct 26, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 974c116 into Lissy93:master Oct 26, 2023
11 checks passed
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants