🚑 Hotfix: Use chokidar to watch only for conf.yml changes

[Lissy93]

Category: Hotfix

Overview
Uses chokidar to watch only for when conf.yml changes.

Uses a custom script (here) to watch for changes (only in conf.yml), and trigger a rebuild. Includes comparing hash of previous file with current one to prevent successive changes, as well as a debounce limit of 5000ms, and some logging.

Issue Number #1494

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

• All changes are backwards compatible
• All lint checks and tests are passing
• There are no (new) build warnings or errors
• (If a new config option is added) Attribute is outlined in the schema and documented
• (If a new dependency is added) Package is essential, and has been checked out for security or performance
• Bumps version, if new feature added

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashy	❌ Failed (Inspect)			Mar 4, 2024 9:30pm

[liss-bot]

yarn.lock changes

Click to toggle table visibility

Name	Status	Previous	Current
chokidar-cli		-	3.0.0
lodash.throttle		-	4.1.1

[netlify]

✅ Deploy Preview for dashy-dev ready!

Name	Link
🔨 Latest commit	1470162
🔍 Latest deploy log	https://app.netlify.com/sites/dashy-dev/deploys/65e63d5a7a3ceb00097383d3
😎 Deploy Preview	https://deploy-preview-1496--dashy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[CrazyWolf13]

Seems good to me for a hotfix, however with this all the problems like favicon, pages and so more, that should have been fixed with this release probably wouldn't be fixed anymore? Or only on a CT reboot.

[Lissy93]

Seems good to me for a hotfix, however with this all the problems like favicon, pages and so more, that should have been fixed with this release probably wouldn't be fixed anymore? Or only on a CT reboot.

They'll still be fixed. This just updates how the app is re-built when changes happen.

Previously it was rebuilding whenever there was any change. I guess that was the issue causing the loop. I tried using chokidar to watch only the conf.yml for changes. That seemed to work, but I don't like adding extra dependencies.

I've just written a script that watches config for changes, and triggers a re-build. Testing it now. But hopefully that removes the need for an extra dependency, while also fixing all the issues which needed a rebuild.

Testing atm.....

[CrazyWolf13]

Seems good to me for a hotfix, however with this all the problems like favicon, pages and so more, that should have been fixed with this release probably wouldn't be fixed anymore? Or only on a CT reboot.

They'll still be fixed. This just updates how the app is re-built when changes happen.

Previously it was rebuilding whenever there was any change. I guess that was the issue causing the loop. I tried using chokidar to watch only the conf.yml for changes. That seemed to work, but I don't like adding extra dependencies.

Love that idea!

I've just written a script that watches config for changes, and triggers a re-build. Testing it now. But hopefully that removes the need for an extra dependency, while also fixing all the issues which needed a rebuild.

Quickly looked over it, looks very good!

Testing atm.....

👍