Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds support for guest access #167

Merged
merged 10 commits into from
Aug 18, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 18, 2021

Lissy93 /FEATURE/guest-access → Lissy93/dashy Commits: 10 | Files Changed: 16 | Additions: 213 Powered by Pull Request Badge

Category: Feature

Overview
Adds support for guest access. This will enable unauthenticated read-only access to a dashboard, even when auth is configured.

Issue Number #56

New Vars

Field Type Required Description
enableGuestAccess boolean Optional When set to true, an unauthenticated user will be able to access the dashboard, with read-only access, without having to login. Requires auth to be configured. Defaults to false.

Screenshot
image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 18, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 788f502

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/611d79482c645e0008b6b6cd

😎 Browse the preview: https://deploy-preview-167--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Aug 18, 2021

This pull request is split into 3 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • docs
  • src

@Lissy93 Lissy93 changed the title WIP: [FEATURE] Adds support for guest access [FEATURE] Adds support for guest access Aug 18, 2021
@Lissy93 Lissy93 merged commit a491817 into master Aug 18, 2021
@Lissy93 Lissy93 deleted the FEATURE/guest-access branch August 18, 2021 21:33
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#167

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant