Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Better Loading UX #183

Merged
merged 8 commits into from
Aug 28, 2021
Merged

[FEATURE] Better Loading UX #183

merged 8 commits into from
Aug 28, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 28, 2021 •
edited by pull-request-badge bot
Loading

Lissy93 /FEATURE/better-loading → Lissy93/dashy Commits: 8 | Files Changed: 14 | Additions: 207 Powered by Pull Request Badge

Category: Feature

Overview

  • During app initialization, show the build progress and status message
  • While requests are being made, show loader at top of screen
  • Also adds some UI improvements to Workspace view

Issue Number N/A

New Vars N/A

Screenshot
This is the screen displayed while the app is building for the first time
App Initialization Screen Recording

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Aug 28, 2021
@netlify
Copy link

netlify bot commented Aug 28, 2021 •
edited
Loading

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: e522e26

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/612a349c52fc020008265344

😎 Browse the preview: https://deploy-preview-183--dashy-dev.netlify.app/

@github-actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
rsup-progress ADDED - 2.0.4

@viezly
Copy link

viezly bot commented Aug 28, 2021 •
edited
Loading

Changes preview:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 5db0909 into master Aug 28, 2021
@Lissy93 Lissy93 deleted the FEATURE/better-loading branch August 28, 2021 13:11
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
@walkxcode
🍱 Adds Clash(X) (Lissy93#183)
b1bfb2e 
Closes Lissy93#183

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lissy93