Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add redirection from HTTP to HTTPS #538

Merged
merged 2 commits into from
Mar 7, 2022
Merged

✨ Add redirection from HTTP to HTTPS #538

merged 2 commits into from
Mar 7, 2022

Conversation

azerioxal
Copy link
Contributor

@azerioxal azerioxal commented Mar 7, 2022

Ateroz Medium Ateroz /feature/526-http-to-https-redirect → Lissy93/dashy Commits: 2 | Files Changed: 3 | Additions: 18 Label Unchecked Tasks

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:
Feature

Overview
Add the ability to redirect from HTTP to HTTPS if using SSL. A middleware for Express was added to ssl-server.js, and it was rearranged to allow for that.

Issue Number #526

New Vars (if applicable)
Added new env var HTTPS_REDIRECT which defaults to true.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@azerioxal azerioxal requested a review from Lissy93 as a code owner March 7, 2022 11:00
@viezly
Copy link

viezly bot commented Mar 7, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: a4e5402

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6225e84f50049500089caf31

😎 Browse the preview: https://deploy-preview-538--dashy-dev.netlify.app

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@Lissy93 Lissy93 merged commit c1fc473 into Lissy93:master Mar 7, 2022
@azerioxal azerioxal deleted the feature/526-http-to-https-redirect branch April 23, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants