-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Localization, adds multi-language support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: 51641d0 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60fd5bbbae6e380007b81372 😎 Browse the preview: https://deploy-preview-99--dashy-dev.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Feature
Overview
I think that it is important for everyone to be able to comfortable use Dashy, even if English is not their native language.
This PR implements the language-switching functionality. All text within the application has been extracted to a single locales file, and this file can then be duplicated and translated into other languages.
Unfortunately, at this time I wasn't able to include any other language, since I only speak English 😞 but now that the functionality is in place, I can look into getting it translated very easily :)
Issue Number N/A
New Vars
The only new variable is
appConfig.language
, an optional property to pre-load a given language. The language can also be updated through the UI once the app is running.language
string
en
oren-GB
. This must be a language that the app has already been translated into. If your language is unavailable, Dashy will fallback to English. By default Dashy will attempt to auto-detect your language, although this may not work on some privacy browsers.Screenshot N/A
Code Quality Checklist (Please complete)