Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-3893: RFC for component library #3139

Closed
wants to merge 14 commits into from

Conversation

antsgar
Copy link
Collaborator

@antsgar antsgar commented Feb 22, 2024

Description

Initial example setup for component library package and example migration of one component (HoverPill component).
To be reviewed in the context of the RFC and together with the document https://lite-farm.atlassian.net/wiki/spaces/LITEFARM/pages/1449918527/RFC%3A+Component+Library,

Jira link:
https://lite-farm.atlassian.net/browse/LF-3893
https://lite-farm.atlassian.net/browse/LF-3895

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@antsgar antsgar marked this pull request as ready for review February 22, 2024 18:25
@antsgar antsgar requested review from a team as code owners February 22, 2024 18:25
@antsgar antsgar requested review from Duncan-Brain and SayakaOno and removed request for a team, Duncan-Brain and SayakaOno February 22, 2024 18:25
@@ -0,0 +1,520 @@

Copy link
Collaborator

@Duncan-Brain Duncan-Brain Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file accidentally commited?

@kathyavini
Copy link
Collaborator

kathyavini commented Feb 26, 2024

I'm wondering if there is a new setup step I am missing for running this branch? After pnpm install in packages/component-library I can't get the webapp to load anymore, I receive this error:

Screenshot 2024-02-26 at 10 20 28 AM

I saw there were pnpm-lock.yaml changes in root that referred to vite (but no package.json updates) -- was something supposed to be installed in the root directory as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants