Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LLPeEditor the ability to name the output file; Fix plugin imports. #1

Closed
wants to merge 5 commits into from

Conversation

crowbarmaster
Copy link

Hello folks! I am the author of BedrockManagementService, A windows service that allows for the automation behind building and maintaining multiple server endpoints. A fellow user and developer contacted me one day, curious as to whether or not I believed BMS would be capable of running LL modified software.

Fast forward to yesterday - I have added functionality via command-line option ("o" or "out") to LLPeEditor that would allow the production of modded executable of a chosen name. As it was already found to be more of a challange than simply renaming the file, a pair of functions were written to process dll files in the plugins folder, renaming the named import to the new, designated filename.
A second command option was added to allow the use of LLPeEditor to simply fix existing plugins to a named executable. The idea here is to allow the user (or in my case, the software), to add a plugin and quickly fix the import, then immediately exit, providing that noPause is also used.

Lastly, I recommend that "q" (for "quiet") be added as an alternative shortcut to noPause. I also recommend here that mPause, the local variable behind noPause, be renamed to "mShouldPause" for clarity purposes.

With all of these changes, running "LLPeEditor" with no command-line options still behaves the same as it did prior to these modifications, minus a few string variations.

Please, let me know what you think, and if some changes should be made to make it work in situations I cannot test for (I see we convert wide-char to char for paths, hopefully I met qualifications here.), I am more than happy to oblige!

Thank you and my best regards,

Crowbarmaster (Tad).

…l libs are updated with the appropriate import module name. Added calls to process plugins and plugins\LiteLoader folders.
…to fix plugins made for vanilla LiteLoader. Using this option blocks all other actions to ensure fast cycle through of plugins.

Suggesting the addition of an alternate "q" command-line flag to pair with "noPause". The "q" here would refer to "quiet". Also suggesting that the local variable "mPause" be renamed the more accurate "mShouldPause".
@nerd-king
Copy link

I am the nerd king, and I vote for this message.

@KawaiiNahida
Copy link
Member

Hey there, Crowbarmaster (Tad)!

First of all, I'm sorry for taking so long to get back to you. I think your idea to modify LLPeEditor to create modded executables sounds pretty cool, but I'm afraid it might not work so well in the LL environment. It could cause some unexpected issues, and I don't want to risk that.

Also, modifying other plugins' import names could lead to some side effects that we might not be able to predict or fix. So, I think it would be best if you could create your own forked version of the software to meet your specific needs.

I hope that makes sense and that you're not too disappointed. Let me know if you have any other questions or if there's anything else I can help you with!

@KawaiiNahida
Copy link
Member

Regarding the command-line interaction issue you mentioned, I would like to assure you that our team will improve it to make it more clear and concise after the LL3 refactoring is completed. We welcome any feedback or suggestions you might have for the new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants