Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results create links to the highlighted search result, but link goes to the page top #201

Closed
tonyahowe opened this issue Aug 3, 2023 · 1 comment
Assignees
Labels
Priority 1 Most important among issues

Comments

@tonyahowe
Copy link
Contributor

When a user does a keyword search in the search box at the top, say for the word "death," the search results show the search phrase in context, highlighted. But it also adds a link to the text. A user would expect the link to go to that location in context, but the link just goes to the top of the edition in question. It would be great if the keyword link could go to the location in context. That may also entail reshaping the KWIC results from the search screen, so the KWICs are separated out?

@tonyahowe tonyahowe added the Priority 1 Most important among issues label Jun 24, 2024
@wsalesky
Copy link
Contributor

@tonyahowe There is no reliable way to link to the results to the correct place on the page. I'm removing the links on the highlighted results.
#318

wsalesky added a commit that referenced this issue Jun 27, 2024
Remove link to nowhere in KWIC results #201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 1 Most important among issues
Projects
None yet
Development

No branches or pull requests

2 participants