Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileSelection Widget #12

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

AlexKnauth
Copy link
Contributor

A companion PR to LiveSplit/livesplit-core#748.

Implements the FileSelection Widget as a button in the settings Gui that opens a file dialog when pressed. The user can select a file, and the WASI-compatible path to that file gets stored in the settings map.

This code won't fully work until after the livesplit-core dependency has been updated, but to help with testing I have this branch to point the dependency at my livesplit-core PR branch: https://github.com/AlexKnauth/asr-debugger/commits/file-selection-demo

@AlexKnauth
Copy link
Contributor Author

The egui_file dependency changed, so I think I need to replace my use of the FileDialog method filter, with either show_files_filter or filename_filter. Depending on which of those I use, I'll need to replace my use of the Filter type with either Filter<PathBuf> or Filter<String>.

@CryZe CryZe merged commit bb6b0e3 into LiveSplit:master Dec 21, 2023
6 checks passed
@CryZe CryZe added the enhancement New feature or request label Dec 21, 2023
@AlexKnauth AlexKnauth deleted the file-selection branch December 21, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants