Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity] bugfixing #97

Merged
merged 14 commits into from
Oct 21, 2024
Merged

[Unity] bugfixing #97

merged 14 commits into from
Oct 21, 2024

Conversation

Jujstme
Copy link
Contributor

@Jujstme Jujstme commented May 11, 2024

Fixed a bug in the logic employed for the path resolution in UnityPointer that could result into not resolving a path correctly.

@Jujstme Jujstme marked this pull request as draft May 13, 2024 04:25
@Jujstme Jujstme changed the title [Unity] UnityPointer bugfixing [Unity] bugfixing May 13, 2024
@Jujstme
Copy link
Contributor Author

Jujstme commented May 13, 2024

Turned out I found a bug in the code speficially for Mono that sometimes prevented proper identification of the assemblies. This PR also fixes it.

@Jujstme Jujstme marked this pull request as ready for review May 13, 2024 16:08
For some reason the scene manager still used the get_module_range function, breaking compatibility with Proton/Wine
Jujstme added a commit to Jujstme/asr that referenced this pull request Jun 12, 2024
@CryZe CryZe merged commit 2ab38e8 into LiveSplit:master Oct 21, 2024
7 checks passed
@Jujstme Jujstme deleted the unity_pointer branch October 21, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants