Do not evaluate /etc/bashrc on non-interactive shells #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
force-pushed
the
feature/update-bashrc-config
branch
from
2fcf423
to
dff88ee
Compare
LnL7
requested changes
Oct 16, 2018
modules/programs/bash/default.nix
Outdated
| @@ -52,6 +52,9 @@ in | |||
| # /etc/bashrc: DO NOT EDIT -- this file has been generated automatically. | |||
| # This file is read for interactive shells. | |||
|
|
|||
| # If not running interactively, don't do anything | |||
| [[ $- != *i* ]] && return | |||
There was a problem hiding this comment.
Breaking out here means the nix tools won't be in PATH over a non interactive ssh connection (eg. distributed builds) Basic things like environment variables should always be configured.
There was a problem hiding this comment.
Sorry I realized it later, I've placed this early return below the basic setup 1a786eb
Setting PATH and environment setup is required in non-interactive shells
This was referenced Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.