Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stage Manager (com.apple.WindowManager) settings as system.defaults.windowmanager #505

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Stage Manager (com.apple.WindowManager) settings as system.defaults.windowmanager #505

wants to merge 4 commits into from

Conversation

AlexOwl
Copy link
Contributor

@AlexOwl AlexOwl commented Aug 26, 2022

No description provided.

malob
malob reviewed Aug 27, 2022
View reviewed changes
Copy link
Contributor

@malob malob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep with the naming convention of other system.defaults options, I think windowmanager should be changed to WindowManager.

modules/system/defaults-write.nix
@@ -41,6 +41,7 @@ let
trackpadBluetooth = defaultsToList "com.apple.driver.AppleBluetoothMultitouch.trackpad" cfg.trackpad;
universalaccess = defaultsToList "com.apple.universalaccess" cfg.universalaccess;
ActivityMonitor = defaultsToList "com.apple.ActivityMonitor" cfg.ActivityMonitor;
windowmanager = defaultsToList "com.apple.WindowManager" cfg.windowmanager;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
windowmanager = defaultsToList "com.apple.WindowManager" cfg.windowmanager;
WindowManager = defaultsToList "com.apple.WindowManager" cfg.WindowManager;

modules/system/defaults-write.nix
@@ -78,6 +79,7 @@ in
trackpadBluetooth
universalaccess
ActivityMonitor
windowmanager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
windowmanager
WindowManager

modules/system/defaults-write.nix
@@ -97,6 +99,7 @@ in
${concatStringsSep "\n" trackpadBluetooth}
${concatStringsSep "\n" universalaccess}
${concatStringsSep "\n" ActivityMonitor}
${concatStringsSep "\n" windowmanager}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${concatStringsSep "\n" windowmanager}
${concatStringsSep "\n" WindowManager}

modules/system/defaults/windowmanager.nix

{
options = {
system.defaults.windowmanager.GloballyEnabled = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system.defaults.windowmanager.GloballyEnabled = mkOption {
system.defaults.WindowManager.GloballyEnabled = mkOption {

modules/system/defaults/windowmanager.nix
'';
};

system.defaults.windowmanager.GloballyEnabledEver = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system.defaults.windowmanager.GloballyEnabledEver = mkOption {
system.defaults.WindowManager.GloballyEnabledEver = mkOption {

modules/system/defaults/windowmanager.nix
'';
};

system.defaults.windowmanager.AutoHide = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system.defaults.windowmanager.AutoHide = mkOption {
system.defaults.WindowManager.AutoHide = mkOption {

modules/system/defaults/windowmanager.nix
'';
};

system.defaults.windowmanager.HideDesktop = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system.defaults.windowmanager.HideDesktop = mkOption {
system.defaults.WindowManager.HideDesktop = mkOption {

@arulagrawal
Copy link

Hi, sorry to bump, but I noticed this PR has been sitting idle for over a year. Maybe @AlexOwl could quickly make the required change or if they are unavailable someone else could?

@clempat
Copy link

clempat commented Mar 12, 2024

I found this pull request while searching for the defaults write com.apple.WindowManager EnableStandardClickToShowDesktop -bool false option to enhance my experience with Yabai. Can you provide an update on adding WindowManager to the project and whether this option will be included?

malko42 added a commit to malko42/nix-darwin that referenced this pull request Jul 11, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
6cf027c 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
@malko42 malko42 mentioned this pull request Jul 11, 2024
Merged
malko42 added a commit to malko42/nix-darwin that referenced this pull request Jul 20, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
55c07ec 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
malko42 added a commit to malko42/nix-darwin that referenced this pull request Jul 20, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
7da98c0 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
malko42 added a commit to malko42/nix-darwin that referenced this pull request Jul 20, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
dbdc19d 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
malko42 added a commit to malko42/nix-darwin that referenced this pull request Jul 21, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
d0cc510 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
malko42 added a commit to malko42/nix-darwin that referenced this pull request Aug 1, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
50ede81 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
malko42 added a commit to malko42/nix-darwin that referenced this pull request Aug 1, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
3dd14e4 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
NoahBres pushed a commit to NoahBres/nix-darwin that referenced this pull request Oct 7, 2024
@malko42
(feature) Add Stage Manager (com.apple.WindowManager) settings as sys…
dfb15ca 
…tem.defaults.windowmanager

All credits go to @AlexOwl. Their [PR](LnL7#505)
looked abandonned so I reported their changes and addressed the change
requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malob malob malob left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexOwl @arulagrawal @clempat @malob