Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-builder: default pass through protocol to nix.buildMachines #877

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

LoganBarnett
Copy link
Contributor

@LoganBarnett LoganBarnett commented Feb 21, 2024

Of note: I have another pull request (#878) which merges together the existing pull requests that add more option handling all around for linux-builder. This is intended as a way to get a gist for these individualized changes.

This commit adds a protocol option for the linux-builder and defaults it to ssh-ng. I have observed it needing this with the following:

$ nix store ping --store ssh://linux-builder
Store URL: ssh://linux-builder

$ nix store ping --store ssh-ng://linux-builder
Store URL: ssh-ng://linux-builder
Version: 2.18.1
Trusted: 0

This seems to make the difference on whether or not Nix picks up linux-builder as an available builder.

This commit adds a protocol option for the `linux-builder` and defaults
it to `ssh-ng`.  I have observed it needing this with the following:

``` sh
$ nix store ping --store ssh://linux-builder
Store URL: ssh://linux-builder

$ nix store ping --store ssh-ng://linux-builder
Store URL: ssh-ng://linux-builder
Version: 2.18.1
Trusted: 0
```

This seems to make the difference on whether or not Nix picks up
`linux-builder` as an available builder.
@domenkozar domenkozar merged commit 208cd70 into LnL7:master Feb 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants