Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code submitted by @GM-Script-Writer-62850 #42

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

LoLei
Copy link
Owner

@LoLei LoLei commented Jan 20, 2021

Please review @GM-Script-Writer-62850

Close #39
Close #40
Close #41

@GM-Script-Writer-62850
Copy link

seems to work as intended on my end, though it looks like the readme.md file need a update on usage, lacks poll and sync

@GM-Script-Writer-62850
Copy link

was looking other some stuff and noticed this:

    rgb = []
    rgb.append(r)
    rgb.append(g)
    rgb.append(b)

    return rgb

you do know you could write that in one short line right? return [r,g,b]

@LoLei
Copy link
Owner Author

LoLei commented Jan 20, 2021

You can refactor that in another patch if you want.

EDIT: Just added it here.

@LoLei LoLei merged commit 783f3f7 into master Jan 21, 2021
@LoLei LoLei deleted the feature/sync-etc branch January 21, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants