Adding Support for Vertical DIRECT keyword for COPY #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added command line support for direct keyword 2. Modified all the DB classes to accept kwargs so they ignore the direct keyword even if its passed in. Also was able to get rid of unnecessary arg for Vertica 3. Added in support for direct in load & replicate 4. Update README & version to reflect new changes
|
Looks good to me, although it would be nice if there was a more generic way to pass arguments that are DB-specific - would need to think about this more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they ignore the direct keyword even if its passed
in. Also was able to get rid of unnecessary arg for
Vertica