-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macro config parsing in core #319
Conversation
✅ Deploy Preview for lodestone-dashboard canceled.
|
✅ Deploy Preview for lodestone-storybook canceled.
|
6bc8037
to
f2ab57e
Compare
I think this PR is directed at the wrong branch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments on how everything works will be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test cases please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some files are changed not related to this PR? you should revert them if that's the case
@CheatCod added comments and fixed those irrelevant files. Just needed to do a merge with dev to get up to date. Also added unit test |
Description
Currently, there is no easy way for macro developers to render custom configs to the front end. This PR contains Typescript parsing logic, which runs independently of the Deno runtime to extract custom config templates defined by the macro developer into SettingManifests. We might need some corresponding frontend logic to test it out.
Type of change
Note: make sure your files are formatted with rust-analyzer