Update README.md with extensive list of location rules and values #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the possible values to the rule types that were previously listed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possible values to the rule types that were previously listed.
I couldn't quite wrap my head around the formatting. Github flavored markdown doesn't support merged cells so a table didn't seem quite right.
I might be able to do HTML tables instead if this formatting isn't good.
I also wonder if the file formats for attachments is really necessary, it is what they include but I can't really figure out why they have ALL of those.
If accepted and merged can you label this PR with #hacktoberfest-accepted
Thank you.
EDIT: Realized this being Markdown might be tougher to review the changes.
Here is the formatted view on my branch https://github.com/Log1x/acf-builder-cheatsheet/blob/37b3b32dabdfbbf434143dba33beeb1a1d3d8f8a/README.md#field-group-locations