Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block view not loading if not generated with a single word #27

Closed
mike-sheppard opened this issue Jul 14, 2020 · 0 comments · Fixed by #34
Closed

Block view not loading if not generated with a single word #27

mike-sheppard opened this issue Jul 14, 2020 · 0 comments · Fixed by #34
Assignees
Labels
bug Something isn't working

Comments

@mike-sheppard
Copy link
Contributor

mike-sheppard commented Jul 14, 2020

Summary
When creating a block with more than a single word, the view is not loaded.

Steps to reproduce

$ wp acorn acf:block NewExampleBlock

Screenshot_2020-07-14_at_13_17_12

Possible fix
I'm not too familiar with the library to fix this, but perhaps if the generated block/widget/partial $name added the spaces, the view would be found. It's not really a problem manually updating it, as I'd edit the name anyways, but it has caught me out a few times! Especially before I knew what the issue was.

# app/Blocks/NewExampleBlock.php
- public $name = 'NewExampleBlock';
+ public $name = 'New Example Block';
@Log1x Log1x added the bug Something isn't working label Jul 14, 2020
@Log1x Log1x self-assigned this Jul 14, 2020
@Log1x Log1x closed this as completed in b5d6731 Jul 29, 2020
alwaysblank added a commit to alwaysblank/acf-composer that referenced this issue Jul 30, 2020
Log1x pushed a commit that referenced this issue Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants