Duplicate Widget ID

[mike-sheppard]

Hey @Log1x thanks for fixing up those other bits, much appreciated. Just run into this weird one today - not sure if it's the way I'm calling get_field() maybe? But trying out the Example widget it appears to have the same issue.

Summary

Multiple widgets return the same widget_id so ACF data returned is always the last widget added (of the same type).

Example

1. wp acorn acf:widget Example
2. Add 2 or more Example widgets with a few unique list items
3. Identical fields will be shown in the view (last added widget)

[Log1x]

If you change https://github.com/Log1x/acf-composer/blob/master/src/Providers/AcfComposerServiceProvider.php#L39 to $this->app->bind – does it work?

[mike-sheppard]

Thanks for looking into it. Looks like the result is the same as before with this change:

$this->app->bind('AcfComposer', function () {
    return $this->compose();
});

[mike-sheppard]

My guess was something to do with the passed $instance - https://github.com/Log1x/acf-composer/blob/master/src/Widget.php#L125 but haven't dived in too deep yet, should be able to spend some time on it this eve.

[Log1x]

man I'm a little stumped on this. it has something to do with the proper variables not passing when initializing the anonymous class. there has to be a way to make it properly work

[mike-sheppard]

So got a hacky 'fix'..

Setting the id from the instance/args seems to fix it? https://github.com/Log1x/acf-composer/blob/master/src/Widget.php#L125

public function widget($args, $instance)
{
+   $this->widget->widget->id  = "widget_{$args['widget_id']}";
    echo Arr::get($args, 'before_widget');