We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
On blog pages, url in the breadcrumb for the last item is set to 1.
Here is a dump of my items :
items
array:2 [▼ 0 => array:2 [▼ "label" => "Accueil" "url" => "http://dev.cormary.com:8888" ] 1 => array:2 [▼ "label" => "Acide hyaluronique" "url" => "1" ] ]
I think, it come from that :
if (is_category()) { return $this->add( single_cat_title('', false), true ); }
Why is there a true as second parameter? I have set the method to :
protected function add(string $key, ?string $value = null, bool $blog = false)
I think $value is casted to a string when pushing the url in
$this->breadcrumb->push( [ 'label' => $key, 'url' => $value, ] );
The text was updated successfully, but these errors were encountered:
fix(crumb): Fix blog items getting invalid URL (Fixes #3)
e8880cc
enhance(crumb): Add the blog page `id` to the blog item
fix(crumb): Fix blog items getting invalid URL (Fixes #3) (#13)
83d81f3
* enhance(crumb): Add the blog page `id` to the blog item * chore(docs): Bump minimum required version to 7.4
Successfully merging a pull request may close this issue.
Hi,
On blog pages, url in the breadcrumb for the last item is set to 1.
Here is a dump of my
items
:I think, it come from that :
Why is there a true as second parameter? I have set the method to :
I think $value is casted to a string when pushing the url in
The text was updated successfully, but these errors were encountered: