fix(directive): Fix @image directive not re-compiling view when using ACF field #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Log1x is there anything I can do to help get this ready for inclusion in the next release? It's my first public PR so open to any feedback if it needs anything changing. |
|
The underlying issue on this was a little more complicated and was hopefully fixed in #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using @image directive with an ACF field name, the Blade view was not re-compiling after updating field value. This PR fixes this bug by moving the
get_fieldcall directly into the Blade echo rather than passing the field value.Closes #117