Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status num versatile #61

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Status num versatile #61

merged 2 commits into from
Jun 13, 2022

Conversation

luizdanielmlima
Copy link
Contributor

Description

Status num, more versatile (accepts not only number type, but string, undefined, null values too). For undefined/null, it will show a "--" on the UI.

Motivation and Context

As described above

How Has This Been Tested?

Storybook tests

Screenshots (if appropriate):

Desktop

iOS + Safari

Android + Chrome

Types of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build (Changes that affect the build system or dependencies)
  • Chore (Other changes that do not modify src or test files)
  • CI (Changes to our CI configration and scripts)
  • Docs (Changes to documentation files)
  • Style (Changes to coding style, like linters and prettier)
  • Refactor (Changes that do not add new functionality or alter current ones)
  • Performance (Performance improvements)
  • Test (Adding or changing tests or the testing setup)
  • Revert (Reverting a previous change)

Checklist:

  • I have made sure my changes work properly on iOS devices running Safari.
  • I have made sure my changes work properly on Android devices running Chrome.
  • I have made sure my changes work properly on Desktop.
  • I have added tests to cover my changes.

Copy link
Contributor

@cld-santos cld-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an excellent example of how tests can help us during the architecture, keep testing!

@cld-santos cld-santos merged commit 49fb939 into main Jun 13, 2022
@logrock-eng
Copy link
Collaborator

🎉 This PR is included in version 6.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2488848447

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.377%

Totals Coverage Status
Change from base Build 2488804034: 0.0%
Covered Lines: 2901
Relevant Lines: 3059

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants