Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for cases, where scorch fails on no-cluster samples #10

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

Rexhaif
Copy link
Contributor

@Rexhaif Rexhaif commented Oct 9, 2020

Quick fix for #9

@LoicGrobol
Copy link
Owner

Wow, that was quick, thank you ! Interestingly, those edge cases were apparently never actually documented (at least not in the 2014 paper :-) but your changes are consistent with the reference implementation (for future ref, this is in the ShowRPF function).

Just one thing : can you make these 0s 0.0s instead for type consistency?

@Rexhaif
Copy link
Contributor Author

Rexhaif commented Oct 9, 2020

Sure, did it
Actually, i was referring to that https://github.com/wikilinks/neleval/blob/68f68414f6a82e3d86761b8d3083e537582bfa7f/neleval/evaluate.py#L281 warning message in neleval library, which also has several coreference resolution metrics implemented

@LoicGrobol LoicGrobol merged commit 9471244 into LoicGrobol:master Oct 9, 2020
@LoicGrobol LoicGrobol linked an issue Oct 9, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scorch fails on samples with no test clusters
2 participants