Proposal #10
Closed
Proposal #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 30, 2019 13:14
We can now still benefit from a cache that can be read (only its updates will fail).
VictorNicollet
requested changes
Jan 2, 2020
| @@ -36,7 +36,8 @@ public AzureCacheProvider(CloudBlobContainer container, bool useStateCache, int | |||
|
|
|||
| private async Task<CloudBlockBlob[]> Blobs(string fullname) | |||
| { | |||
| await _container.CreateIfNotExistsAsync(); | |||
There was a problem hiding this comment.
It seems redundant to call ExistsAsync() before calling CreateIfNotExistsAsync(). You should add a comment explaining why this call is in fact necessary.
There was a problem hiding this comment.
Indeed.
I am adding comments and switching the second call to a more explicit CreateAsync() call.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading big events store will look less like a deadlock with additional logs regarding the initial catch-up.
Also adds a ConfigureAwait(false) that shouldn't do any harm...