Add TransparentWrapper marker trait #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
force-pushed
the
transparent
branch
2 times, most recently
from
8794b94
to
7cca499
Compare
|
The last commit here arguably should be another PR, but I think I'm the one who wrote the doctests anyway, so whatever. |
Lokathor
approved these changes
Jan 29, 2020
leod
pushed a commit
to leod/bytemuck
that referenced
this pull request
Jun 3, 2023
Add TransparentWrapper marker trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That transmute_copy bothers me, and I'd like have a "do sizes match" sanity check for broken impls... But supporting &[T] to &SomeStruct([T]) is too useful to give up IMO.
Unsure on where wrap_ref/wrap_mut should go. I don't really like "hey don't implement this" functions on the trait, but maybe they'd be better there.