-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some functions, fix some stuff #4
Conversation
BOOL should be an alias of c_int Make c_struct! generated structs' fields public Add GetProcAddress and DescribePixelFormat
There are a lot of other constant types that are wrong, but 🤷 As per #2, is the convention meant to be that consts are left as |
There's places where the C api isn't even consistent about what type a value is supposed to be, is the problem. I can accept the new types and externs, but the changes to types are a breaking change technically. If there is gonna be a 2.0 we should go farther and use more actual newtyping and repr(transparent) stuff. Like the newer style in the windows-rs crate. |
Ah, right, those would be a breaking changes. In the meantime, I guess we are stuck with casting constants as necessary? (Or taking the module approach, as described in #2) |
The pub fields thing is technically also a breaking change, though, (AFAICT) and that's just broken w/o a workaround. Can that be merged, at least? |
making the fields But going from some amount of private to all public is legal. |
Ah, right, I'm only making private fields public not adding new fields. Got confused there. |
BOOL
should be a typedef forc_int
PFD_TYPE_RGBA
,PFG_TYPE_COLORINDEX
,PFD_MAIN_PLANE
,PFD_OVERLAY_PLANE
, andPFD_UNDERLAY_PLANE
should beBYTE
c_struct!
should generate structs with public fieldsGetProcAddress
DescribePixelFormat
FARPROC
NEARPROC