Implement std::error::Error to ease type erasure #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Box<Error>::from(...) is implemented by default for anything that implements Error, and `?` uses from by default, making this handy for anything dealing with multiple error types. - Since CI targets 1.24.0, implement the soft-deprecated description() - Implementing Error requires implementing Display. - Also ignore warnings about not using `&dyn Debug` while we're at it.
|
I wanted to go the opposite direction and have it be no_std, but we could probably put this behind a feature flag if so. I'll let this sit a bit and think on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box::from(...) is implemented by default for anything that
implements Error, and
?uses from by default, making this handy foranything dealing with multiple error types.
&dyn Debugwhile we're at it.