Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AJAX #25

Merged
merged 31 commits into from
Jun 20, 2023
Merged

AJAX #25

merged 31 commits into from
Jun 20, 2023

Conversation

adrianHards
Copy link
Collaborator

@adrianHards adrianHards commented Jun 19, 2023 •
edited
Loading

Changes

  • abstracted away code from controllers into a folder called services
  • abstracted away code from posts index page into partials (this was also needed for AJAX)
  • wrote AJAX for index page; can now like, comment and create a new post without a page refresh
  • this also works on newly created posts!

To Do:

  • have tests pass

@adrianHards
break index into partials
add8919
@adrianHards
ajax for posts
d52a910
@adrianHards
abstract away code from the posts controller
78ce04f
@adrianHards
abstract away code from other controllers
a688b85
@adrianHards
refactor posts to ajax comment
6a855e6
@adrianHards
refactor partials
b8e6fcc
@adrianHards
move ajax js in to public folder
b316f86
@adrianHards
ajax working for comments
f59b761
@adrianHards
add id to new post to enable comments on that post
52ed202
@adrianHards
ajax comments
29aec5e
@adrianHards
remove unncessary files
c9ce8eb
@adrianHards
new posts aren't pokeable
7149e84
@adrianHards
ajax of likes works on existing posts
41cfbf4
@adrianHards
ajax of likes for a new post
8cb72bd
@adrianHards
pass unit tests
a5a7ca9
@adrianHards
create new post
0e512bf
@adrianHards
refactor code
800005d
@adrianHards
refactor ajax js code into diff files
d684d12
@adrianHards
prettier
6e991fd
@adrianHards
redirect to sign in if not before visiting posts
333bb03
@adrianHards
reset form on submit
125d768
@adrianHards
remove lines from e2e
74d097f
@adrianHards
add user who liked post even if new post
bdcb3b3
@adrianHards
failing e2e edits
fd824fe
@adrianHards
fix handler and refactor target
0925666
@adrianHards
remove spacing around 0
8cbe5ed
@adrianHards
passing 4 and 7
191e831
@adrianHards
passing all tests
f1022d6
@adrianHards
merge edit and delete
bf80e02
@adrianHards adrianHards merged commit f846ab3 into main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmadavids emmadavids emmadavids approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianHards @emmadavids