feat: Merkle tree length checks and other optimizations #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xhiroshi
reviewed
Jan 30, 2023
0xhiroshi
approved these changes
Jan 30, 2023
0xJurassicPunk
changed the title
|
0xhiroshi I'll update the OrderValidatorV2A once this one is merged. #376 |
0xhiroshi
reviewed
Jan 31, 2023
contracts/libraries/OpenZeppelin/MerkleProofCalldataWithProofLimit.sol
Outdated
Show resolved
Hide resolved
0xhiroshi
reviewed
Jan 31, 2023
0xhiroshi
reviewed
Jan 31, 2023
| bytes memory signature = _signMerkleProof(merkleTree, makerUserPK); | ||
|
|
||
| // Verify validity | ||
| // TODO |
There was a problem hiding this comment.
@0xJurassicPunk what is this supposed to be
0xhiroshi
reviewed
Jan 31, 2023
| OrderStructs.TakerBid memory takerBid = OrderStructs.TakerBid( | ||
| takerUser, | ||
| makerAsk.minPrice, | ||
| makerAsk.itemIds, |
There was a problem hiding this comment.
There is going to be a merge conflict with the taker struct refactor
0xhiroshi
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: