chore: Simplify usage for collection orders #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xhiroshi
reviewed
Mar 16, 2023
0xhiroshi
reviewed
Mar 16, 2023
0xhiroshi
reviewed
Mar 17, 2023
| import abiIERC721 from "../../abis/IERC721.json"; | ||
| import { Signer } from "../../types"; | ||
|
|
||
| export const balanceOf = async (signer: Signer, contractAddress: string, owner?: string, overrides?: Overrides) => { |
There was a problem hiding this comment.
do you still need a signer for readonly functions?
There was a problem hiding this comment.
No but because it's a helper for the test, it makes it easier (I can ignore the address and pull it from the signer)
0xhiroshi
reviewed
Mar 17, 2023
0xShisui
force-pushed
the
collection-orders
branch
from
98bc427
to
359264b
Compare
0xhiroshi
previously approved these changes
Mar 17, 2023
0xShisui
force-pushed
the
collection-orders
branch
from
359264b
to
9b82a42
Compare
0xShisui
force-pushed
the
collection-orders
branch
from
9b82a42
to
e62155d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.