[Protocol3] Add unit tests for UniversalRegistry(#403) #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchen0510
changed the title
adamchen0510
changed the title
|
It's ready, please help to review. |
dong77
approved these changes
Oct 19, 2019
ghost
pushed a commit
that referenced
this pull request
Oct 24, 2019
kongliangzhong
pushed a commit
that referenced
this pull request
Oct 24, 2019
* update loopring_v3.js * modify config * add keypair & password feature && unit test * modify market config * add approve zero function * rename market * modify get key pair and sign apikey * fix password * new package lightcone_v3.js * rename package name * modify * modify * [Lightcone_v3.js] modify permission (#605) * modify permission * modify to string * fix beta3 * modify to beta3 rinkeby * Bump node from 12.11.0 to 12.11.1 (#572) Bumps [node](https://github.com/aredridel/node-bin-gen) from 12.11.0 to 12.11.1. - [Release notes](https://github.com/aredridel/node-bin-gen/releases) - [Commits](https://github.com/aredridel/node-bin-gen/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump lerna from 3.16.4 to 3.16.5 (#573) Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.16.4 to 3.16.5. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.16.5/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @types/node from 12.7.11 to 12.7.12 (#574) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.7.11 to 12.7.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Protocol3] Exchange module refactor (#575) * [Protocol3] Initial commit protocol 3.1 * [Protocol3] Changes for feedback in review * Update README.md * fix eth config (#583) * Bump truffle from 5.0.39 to 5.0.40 (#580) Bumps [truffle](https://github.com/trufflesuite/truffle) from 5.0.39 to 5.0.40. - [Release notes](https://github.com/trufflesuite/truffle/releases) - [Commits](https://github.com/trufflesuite/truffle/compare/truffle@5.0.39...truffle@5.0.40) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump typescript from 3.1.6 to 3.6.4 (#579) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.1.6 to 3.6.4. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v3.1.6...v3.6.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @types/node from 12.7.11 to 12.7.12 (#578) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.7.11 to 12.7.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump lerna from 3.16.5 to 3.17.0 (#576) Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.16.5 to 3.17.0. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.17.0/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * move getContants function to ExchangeV3 (#582) * move getContants function to ExchangeV3 * update * Bump node from 12.11.1 to 12.12.0 (#585) Bumps [node](https://github.com/aredridel/node-bin-gen) from 12.11.1 to 12.12.0. - [Release notes](https://github.com/aredridel/node-bin-gen/releases) - [Commits](https://github.com/aredridel/node-bin-gen/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * use github for npm registry (#587) * use github for npm registry (#588) * Bump lerna from 3.17.0 to 3.18.1 (#598) Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.17.0 to 3.18.1. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.18.1/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @types/node from 12.7.12 to 12.11.1 (#596) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.7.12 to 12.11.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump async-validator from 3.1.0 to 3.2.0 (#595) Bumps [async-validator](https://github.com/yiminghe/async-validator) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/yiminghe/async-validator/releases) - [Changelog](https://github.com/yiminghe/async-validator/blob/master/HISTORY.md) - [Commits](https://github.com/yiminghe/async-validator/commits/v3.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump husky from 3.0.8 to 3.0.9 (#592) Bumps [husky](https://github.com/typicode/husky) from 3.0.8 to 3.0.9. - [Release notes](https://github.com/typicode/husky/releases) - [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md) - [Commits](typicode/husky@v3.0.8...v3.0.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @types/bluebird from 3.5.27 to 3.5.28 (#591) Bumps [@types/bluebird](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/bluebird) from 3.5.27 to 3.5.28. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/bluebird) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump pretty-quick from 1.11.1 to 2.0.0 (#593) Bumps [pretty-quick](https://github.com/azz/pretty-quick) from 1.11.1 to 2.0.0. - [Release notes](https://github.com/azz/pretty-quick/releases) - [Commits](prettier/pretty-quick@v1.11.1...v2.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump es6-promisify from 5.0.0 to 6.0.2 (#577) Bumps [es6-promisify](https://github.com/digitaldesignlabs/es6-promisify) from 5.0.0 to 6.0.2. - [Release notes](https://github.com/digitaldesignlabs/es6-promisify/releases) - [Commits](mikehall314/es6-promisify@v5.0.0...v6.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump webpack from 3.12.0 to 4.41.2 (#597) Bumps [webpack](https://github.com/webpack/webpack) from 3.12.0 to 4.41.2. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v3.12.0...v4.41.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Protocol3] Add unit tests for ProtocolFeeVault (#265) (#594) * Refine comment * Add zero condition * Add testProtocolFeeVault * Add more tests * Remove isAmountCloseEnough which not needed * Clean fundDao event check * Enable sellTokenForLRC * Add claimReward before getProtocolFeeStats * Bump truffle from 5.0.40 to 5.0.41 (#602) Bumps [truffle](https://github.com/trufflesuite/truffle) from 5.0.40 to 5.0.41. - [Release notes](https://github.com/trufflesuite/truffle/releases) - [Commits](https://github.com/trufflesuite/truffle/compare/truffle@5.0.40...truffle@5.0.41) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Protocol3] Test signature-based whitelist implementation (#599) * [Protocol3] Try solidity-coverage (#604) * [Protocol3] change isAddressWhitelisted to view function (#606) * [Protocol3] Add unit tests for UniversalRegistry(#403) (#600) * Bump lerna from 3.18.1 to 3.18.2 (#613) Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.18.1 to 3.18.2. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.18.2/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @types/node from 12.11.1 to 12.11.2 (#612) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.11.1 to 12.11.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Protocol3] emit BlockFinalized event only once (#614) * Bump @types/node from 12.11.2 to 12.11.5 (#618) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.11.2 to 12.11.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump lerna from 3.18.2 to 3.18.3 (#617) Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.18.2 to 3.18.3. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.18.3/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * REVERT [Protocol3] emit BlockFinalized event only once (#614) (#619) * [Protocol3] Add missed const cases (#621) * [Protocol3] Add another constant MAX_TIME_TO_DISTRIBUTE_WITHDRAWALS_IN_SHUTDOWN_MODE (#615) * Revert "[Protocol3] Add missed const cases (#621)" (#625) This reverts commit 137e598. * update loopring_v3.js * Bump web3 from 1.2.1 to 1.2.2 (#626) Bumps [web3](https://github.com/ethereum/web3.js) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/ethereum/web3.js/releases) - [Changelog](https://github.com/ethereum/web3.js/blob/v1.2.2/CHANGELOG.md) - [Commits](web3/web3.js@v1.2.1...v1.2.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * modify to master latest * add dist dir to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.