-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/duplex #324
Feature/duplex #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, needs to be certain about strand types at specific places!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the logic is clearer, I've made a couple of comments but I think that this is there!
Has it been run against a live/simulated device?
It has been tested live.... waiting to interpret those tests. |
bumps coverage >72
WHO wrote this literally crying
…rride, And we were going to unblock this one
So it can be inverted with bitwise NOT to the opposite strand
Fix comparisons of chemistry enum Delete unused code
use new bitwise NOT on strand for possible duplex
Fix typod variable
Move storing duplex tracker alignments/decisions into it's own conditional block
9368620
to
0e823bd
Compare
3bfe556
to
159e49e
Compare
159e49e
to
25ebfb1
Compare
This works - @alexomics and @mattloose I'd like to merge so we can address #347 and avoid this languishing so long it no longer works |
Yes - we know that this works now. I'm happy to merge it. |
… chemistry settings
@alexomics blocked by your requested change for being certain about |
Two implementations of simple duplex targeting
Initial implementation of the "chill" accept if the previous read was deliberately sequenced, and this one otherwise wouldn't be, which has been included to account for sequencing duplex with
no_map
as the decision.The slightly more complex previous alignment was sequenced, and this read aligns to the opposite strand on the same contig.
Both of these modes break the chain of
stop_receiving
if the previous read was only sequenced if it was potentially duplex, by checking the newduplex_override
decision, on theduplex_tracker
.Other things of note: