Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config for mysql 8 #650

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Fix config for mysql 8 #650

merged 3 commits into from
Oct 2, 2023

Conversation

edeno
Copy link
Collaborator

@edeno edeno commented Sep 29, 2023

Update config files to work with mysql 8

@edeno edeno requested a review from CBroz1 September 29, 2023 22:40
@edeno edeno changed the title Fix dj add user Fix config for mysql 8 Sep 30, 2023
CBroz1
CBroz1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without testing, everything looks right. Either now or in the future, I would...

  1. Change file write, then execute to dj.conn().query, which can run the SQL directly
  2. Migrate all of these items to spyglass/cli rather than this root level folder

@edeno edeno merged commit ec56049 into master Oct 2, 2023
9 checks passed
@edeno edeno deleted the fix-dj-add-user branch October 2, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edeno @CBroz1