53 create operation modules #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented class as a child class of adder, as it has the same functionality, with the difference of having the B input negated
Calculate output is now protected so subtractor class can use it
set_B method overriden so that input b will be not(value)
Subtractor is now its own class, used only for pure-binary, unless input converted to two's complement.
Test subtractor
Subtractor
TEST TO BE EXECUTED!!
Fixed __calculate_output method - Shifter can now shift left or right - User can choose the number of positions to shift
Added dir atribute, used to select the direction the shhifter will shift it's contents
Added tests for shifter module
Shifter module
Fixed asignation of output and missing exception
Extender test
Cero extend
Tested conversor
LovetheFrogs
added
enhancement
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.