Adding s390x support for LuaJIT #891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I have just tried to build https://github.com/DNS-OARC/dnsjit on Fedora. It has failed with this patch with following: It seems some forgotten pieces do not support s390x as it should. |
|
(i am not luajit maintainer, just tried to use it on depending package). |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR of adding support of LuaJIT to s390x. In this PR I have addressed the disassembler for s390x, fixed expected outputs and added JIT compatibility by modifying vm_s390x.dasc as well as adding necessary labels.
Criticism is welcomed! 😃