Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added field on the Weather object #39

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Added field on the Weather object #39

merged 1 commit into from
Nov 6, 2022

Conversation

JigolKa
Copy link
Contributor

@JigolKa JigolKa commented Nov 5, 2022

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Parsed the response data to get the image corresponding to the current weather

lib/core/nodes/Weather.js:45 Since Axios does not execute the javascript for us, the image's src is not be found in the image's attributes, but in a script tag.

PS: Some of my changes are made by my formatter, so sorry in advance

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Parsed the response data to get the image corresponding to the current weather
* Since Axios does not execute the javascript for us, the image's src is not be found in the image's attributes, but in a script tag.
@LuanRT
Copy link
Owner

LuanRT commented Nov 6, 2022

Sweet, thank you!

@LuanRT LuanRT merged commit ff3084d into LuanRT:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants