Preserve line endings when editing file in insert_license hook #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiftachkarkason
force-pushed
the
preserve-line-endings-in-insert-license
branch
2 times, most recently
from
7e5035b
to
70105f1
Compare
yiftachkarkason
force-pushed
the
preserve-line-endings-in-insert-license
branch
from
70105f1
to
b9fc508
Compare
|
Thank you for your contribution @yiftachkarkason! I'm planning to merge your PR as soon as this other one passes and lands on |
Awesome! Let me know if you need help with #85 👍 |
|
Thank you for your contribution! This is now released: https://github.com/Lucas-C/pre-commit-hooks/releases/tag/v1.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve line endings format when editing a file in
insert_licensehook.This was problematic on Windows, when using
--fuzzy-match-generates-todo- the line endings were always changed to CRLF.