Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlight via tree-sitter-highlight #301

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

LucasPickering
Copy link
Owner

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Add syntax highlighting to the three places where we show bodies: Recipe pane, Request tab, Response Body tab.

image

image

image

This took a lot of fucking around to maintain template preview styles on top of syntax highlighting.

Closes #264

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

There's almost definitely bugs in here. There's even some weird stuff that may be bugs but I'm choosing to ignore. I did my best to make sure there's no dramatic perf impact or crashes, so anything else negative is not going to be an obstruction, and is most likely fixable later.

QA

How did you test this?

Added a couple unit tests, tested various scenarios in the TUI. Definitely under tested, but like I said above, I'm fairly confident it doesn't break anything and the rest is just bonus.

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering merged commit 2968c17 into int/2.0 Jul 28, 2024
7 checks passed
@LucasPickering LucasPickering deleted the highlight-treesitter branch July 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant