[i18n-input] Added component handling i18n translations for a single input #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obraud
force-pushed
the
feat/lu-i18n-input
branch
from
2f78dd5
to
096b322
Compare
|
Closing in favor of #2890 to use new popover. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V1:
The input in itself is a attribute component which prevents using it with other attribute component like
luButton. It also implementsControlValueAccessorwhich will cause conflicts if used with otherControlValueAccessorcomponent or directives.V2:
The input is a text form control. Panel has been simplified to be submit when clicking outside of it.