Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Tikz Backend #15

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Refactored Tikz Backend #15

merged 6 commits into from
Apr 11, 2023

Conversation

Lugrim
Copy link
Owner

@Lugrim Lugrim commented Apr 10, 2023

  • Moved bounding box logic out of the pass for it to be usable by other passes
  • Splitted Tikz Backend into several smaller functions
  • Load template file the same way as HTML Backend (will make things easier when making an actual template engine)

@Lugrim
💡 Commented a bit TikzBackend apply function
6ac2f8c
@Lugrim
♻ Moved bounding box logic
ae4e065 
As Bounding-Box is related to an event list, it maes more sense to have
its logic in `event.rs` than in a specific compilation pass.
@Lugrim
♻️ Splitted apply for TikzBackend into several functions
5e6054e
@Lugrim
🧱 Can now load tex template from file
b050fda
@Lugrim Lugrim linked an issue Apr 10, 2023 that may be closed by this pull request
tikz compilation application is too long #11
Closed
Lymkwi
Lymkwi reviewed Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@Lymkwi Lymkwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. We talked about a couple things that could be improved.

src/event.rs Outdated Show resolved Hide resolved
src/event.rs Outdated Show resolved Hide resolved
src/event.rs Outdated Show resolved Hide resolved
src/passes/latex.rs Show resolved Hide resolved
src/passes/latex.rs Outdated Show resolved Hide resolved
src/passes/latex.rs Outdated Show resolved Hide resolved
src/passes/latex.rs Outdated Show resolved Hide resolved
src/passes/latex.rs Outdated Show resolved Hide resolved
@Lugrim
♻️ Factored out boundary calculation
1dbf215 
Now using `std::Cmp::Ordering`
Lymkwi
Lymkwi reviewed Apr 10, 2023
View reviewed changes
src/passes/latex.rs Outdated Show resolved Hide resolved
hugnata
hugnata approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@hugnata hugnata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 😃

data/template_tikz.tex Show resolved Hide resolved
src/event.rs Show resolved Hide resolved
Docteur-Lalla
Docteur-Lalla approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@Docteur-Lalla Docteur-Lalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

@Lugrim Lugrim mentioned this pull request Apr 11, 2023
Closed
@Lugrim Lugrim merged commit 382956b into main Apr 11, 2023
@Lugrim Lugrim deleted the tikz-refactor branch April 11, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lymkwi Lymkwi Lymkwi left review comments

@Docteur-Lalla Docteur-Lalla Docteur-Lalla approved these changes

@hugnata hugnata hugnata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tikz compilation application is too long
4 participants
@Lugrim @Docteur-Lalla @Lymkwi @hugnata