Session testing #72
Merged
Session testing #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit revises the logout method of the admin utility for tests. The logout method will now only attempt to log out a session if there is already a valid token saved. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit increases the test timeout to allow for the delayed update of sessions in the admin api. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit adds session tests to isolate issue #71. This commit adds two tests to the test suite. The first test replicates the issue reported reported in the issue. The second tests ensure new sessions are created to prevent collisions. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit expeands testing to include all tests. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit revises the agent model request and watch methods. This commit should solve issue #71 and causes newly added tests to pass. This commit revises the request method to eject any current intercepter when a new request is called. This commit also revises the agent watch method to only create a session when their are pending requests and wait until there is an available session before queuing requests. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit updates multiple models to fix an issue preventing sessions from being saved and tracked by the clients. This commit should close #71. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
This commit prevents the queue test from timing out by adding concurrency to the queue test. This commit causes all test to pass after fixing issue #71. Signed-off-by: Lui de la Parra <Lui@mutesymphony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates multiple models to solve an issue (#71) where sessions are not reused. This PR modifies multiple models and methods. This commit modifies the agent, connection, and session models.
The agent model's watch method has been updated to iterate through sessions. The agent model will deactivate any session that has an empty request id. The watch method logic has also been updated to ensure it properly waits for an available session. The agent request method has been updated to fix an issue where multiple axios interceptors would be registered for an instance.
The connection model has been revised to remove the ready method and add a confirm and deactivate method. The confirm method will iterate through sessions and deactivate any sessions that are in an unknown state. The deactivate method will target a specific session for deactivation given an authorization header or id.