Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): correct file name #13

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

wazazaby
Copy link
Contributor

Hi again!

A new PR to fix the example file's name so that it can be ran.

I also added an example to show how non-present fields behave with gonull.

Thanks :)

The proper naming convention for example files
is *_test.go so that they can be ran like tests.
@wazazaby wazazaby marked this pull request as ready for review December 30, 2023 17:47
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed7f29e) 100.00% compared to head (cd8ac99) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           59        59           
=========================================
  Hits            59        59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukaGiorgadze LukaGiorgadze added the bug Something isn't working label Dec 30, 2023
@LukaGiorgadze
Copy link
Owner

Thank you @wazazaby !

@LukaGiorgadze LukaGiorgadze merged commit 8b16952 into LukaGiorgadze:main Dec 30, 2023
7 checks passed
@wazazaby wazazaby deleted the fix/example-file branch December 30, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants