Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --fail-first flag #43

Closed
wants to merge 5 commits into from

Conversation

markusa380
Copy link

No description provided.

@LukasKalbertodt
Copy link
Owner

Hey and thanks for the PR! If I'm not mistaken, --fail-first is not a flag in the built-in libtest right? So this would be an additional feature of libtest-mimic, right? Generally I try to avoid those, as then there is no end to what useful features one could add to this library. Do you have a special reason to add this? What's your use case?

@markusa380
Copy link
Author

markusa380 commented Jun 28, 2024

I understand your point, yes.
We are using this feature in our company's project, as we use libtest-mimic to run a large test suite for our query engine.
We want this test suite to stop running on the first error in CI to save considerable time and resources.

@LukasKalbertodt
Copy link
Owner

I have to reject this feature request at this time. As I said: this crate aims to be a direct replacement for the built-in test harness, with basically no additional features. Otherwise, the scope could explode, as there are always interesting features one can add.

As for your use case: you can fairly easily implement a fail-first approach on top of this crate. You pass runner functions to libtest_mimic::run, so you can simply have some boolean flag failed and check that before actually running the test. It's not as nice as if it was built in, but it's still doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants