-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(twig): support storybook twig extension in linting #613
feat(twig): support storybook twig extension in linting #613
Conversation
The automatic twig linting throws a fatal error when the Storybook module is present, as the static tests don't bootstrap Drupal to discover twig extensions. Since bootstrapping Drupal is expensive, instead check and load the twig extension manually. Re Lullabot/appstate-drupal#33 (comment)
The test failed creating a Pantheon multidev environment with a 403. I'm rerunning in case it was a transient error. I don't think it could have affected this PR. |
@deviantintegral I see you approved this. Does that mean the failed
|
@mrdavidburns yeah, it is. See there's a 403 from Terminus? This part of the code only runs in ddev in github actions. But it is odd that #611 passed. I'm going to rerun. |
Ohhh this is because this was created from a fork, where we don't pass secrets on. Since I am confident this code isn't used in any Pantheon steps, I'm going to override and merge. |
fixes: #615
The automatic twig linting throws a fatal error when the Storybook module is present, as the static tests don't bootstrap Drupal to discover twig extensions. Since bootstrapping Drupal is expensive, instead check and load the twig extension manually.