Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

[Re: #55] Get in good default .twig files (and if needed some default Scss) #59

Closed
64 tasks done
wesruv opened this issue Jun 25, 2015 · 3 comments
Closed
64 tasks done
Assignees
Labels

Comments

@wesruv
Copy link
Contributor

wesruv commented Jun 25, 2015

Looked at stealing stuff from Classy, it has the markup and classes that we don't want, but if we use stuff from Core we get a pretty barren looking site.

Going to include some default Sass components in Windup for things that we're used to getting 'for free' e.g. the admin tabs. By default in D8 (if you're not using classy) they come in as unstyled ul and li's, adding default styles will give us the option of not worrying about those things unless we want to, but we also have the complete control to completely delete those styles/markup if the theme based on Windup wants to do something else.

Reviewed files

  • admin/maintenance-page.html.twig
  • admin/maintenance-task-list.html.twig
  • admin/menu-local-action.html.twig
  • admin/menu-local-task.html.twig
  • admin/menu-local-tasks.html.twig
  • admin/status-messages.html.twig
  • blocks/block--search-form-block.html.twig
  • blocks/block--system-branding-block.html.twig
  • blocks/block--system-menu-block.html.twig
  • blocks/block--system-messages-block.html.twig
  • blocks/block-list.html.twig
  • blocks/block.html.twig
  • content/comment.html.twig
  • content/node.html.twig
  • content/taxonomy-term.html.twig
  • fields/field.html.twig
  • field/field--node--created.html.twig
  • field/field--node--title.html.twig
  • field/field--node--uid.html.twig
  • field/file-link.html.twig
  • form/checkboxes.html.twig
  • form/confirm-form.html.twig
  • form/datetime-form.html.twig
  • form/datetime-wrapper.html.twig
  • form/field-multiple-value-form.html.twig
  • form/fieldset.html.twig
  • form/form-element-label.html.twig
  • form/form-element.html.twig
  • form/form.html.twig
  • form/input.html.twig
  • form/radios.html.twig
  • form/select.html.twig
  • form/textarea.html.twig
  • html-elements/image.html.twig
  • html-elements/item-list.html.twig
  • html-elements/links.html.twig
  • html-elements/responsive-image-formatter.html.twig
  • html-elements/responsive-image.html.twig
  • html-elements/table.html.twig
  • html-elements/tablesort-indicator.html.twig
  • html-elements/time.html.twig
  • html.html.twig
  • navigation/breadcrumb.html.twig
  • navigation/menu.html.twig
  • navigation/pager.html.twig
  • page.html.twig
  • region.html.twig
  • views/views-exposed-form.html.twig
  • views/views-mini-pager.html.twig
  • views/views-view-field.html.twig
  • views/views-view-fields.html.twig
  • views/views-view-grid.html.twig
  • views/views-view-grouping.html.twig
  • views/views-view-list.html.twig
  • views/views-view-mapping-test.html.twig
  • views/views-view-opml.html.twig
  • views/views-view-row-opml.html.twig
  • views/views-view-row-rss.html.twig
  • views/views-view-rss.html.twig
  • views/views-view-summary-unformatted.html.twig
  • views/views-view-summary.html.twig
  • views/views-view-table.html.twig
  • views/views-view-unformatted.html.twig
  • views/views-view.html.twig
@wesruv wesruv self-assigned this Jun 25, 2015
@wesruv
Copy link
Contributor Author

wesruv commented Jun 25, 2015

PR here: #69

wesruv added a commit that referenced this issue Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few.
Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some
Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to
That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv added a commit that referenced this issue Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few.
Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some
Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to
That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv added a commit that referenced this issue Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few.
Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some
Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to
That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv added a commit that referenced this issue Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few.
Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some
Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to
That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv added a commit that referenced this issue Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few.
Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some
Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to
That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv added a commit that referenced this issue Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few.
Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some
Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to
That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
@carwin carwin added the 8.x label Jul 15, 2015
@carwin
Copy link
Contributor

carwin commented May 25, 2016

@wesruv now that d8 is released and we just pulled in all the new templates to review, I've reset the list. So far I've looked at page.html.twig and region.html.twig but they could probably use more eyeballs. We should probably close #69 and start fresh.

@carwin
Copy link
Contributor

carwin commented May 31, 2016

To be honest, I stopped reviewing all these once I got to the view templates. For now I figure we can just leave them where they are in their default state and once we get some experience with working with views in D8 we can update them. But this way we don't have to go through aaaaaaaallll the hard work of copying and pasting them, right?

The rest are done for now. I'm sure we'll see updates in the future.

@carwin carwin closed this as completed May 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants