This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
[Re: #55] Get in good default .twig files (and if needed some default Scss) #59
Closed
64 tasks done
Labels
Comments
PR here: #69 |
wesruv
added a commit
that referenced
this issue
Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few. Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv
added a commit
that referenced
this issue
Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few. Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv
added a commit
that referenced
this issue
Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few. Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv
added a commit
that referenced
this issue
Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few. Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv
added a commit
that referenced
this issue
Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few. Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv
added a commit
that referenced
this issue
Jun 25, 2015
I haven't been able to go through all of these yet, it is likely we'll be able to remove quite a few. Thought it'd be easier to include all of the ones we *might* need and remove than risk missing some Also adding some basic styling for primary tabs, haven't added styling for secondary tabs or actions, but intend to That way we have a good default for something we're used to 'taking for granted' in 7 and have the option of modifying/rewriting the default
wesruv
added a commit
that referenced
this issue
May 25, 2016
wesruv
added a commit
that referenced
this issue
May 25, 2016
carwin
added a commit
that referenced
this issue
May 31, 2016
carwin
added a commit
that referenced
this issue
May 31, 2016
carwin
added a commit
that referenced
this issue
May 31, 2016
To be honest, I stopped reviewing all these once I got to the view templates. For now I figure we can just leave them where they are in their default state and once we get some experience with working with views in D8 we can update them. But this way we don't have to go through aaaaaaaallll the hard work of copying and pasting them, right? The rest are done for now. I'm sure we'll see updates in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Looked at stealing stuff from Classy, it has the markup and classes that we don't want, but if we use stuff from Core we get a pretty barren looking site.
Going to include some default Sass components in Windup for things that we're used to getting 'for free' e.g. the admin tabs. By default in D8 (if you're not using classy) they come in as unstyled ul and li's, adding default styles will give us the option of not worrying about those things unless we want to, but we also have the complete control to completely delete those styles/markup if the theme based on Windup wants to do something else.
Reviewed files
The text was updated successfully, but these errors were encountered: