This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Switch to libsass #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| spawn: false | ||
| } | ||
| } | ||
| }, | ||
| clean: { | ||
| css: ['css/style.css', 'scss/_component.scss', 'scss/_layout.scss', 'scss/_skin.scss'] |
There was a problem hiding this comment.
I get why clean is specified on 'css/style.css' but why 'scss/_component.scss', 'scss/_layout.scss', 'scss/_skin.scss' ?
There was a problem hiding this comment.
They're auto-generated files through sass globbing
| @@ -84,19 +80,13 @@ $ grunt wiredep | |||
| Sass files will be added into scss/_vendor.scss | |||
|
|
|||
| ```bash | |||
| $ bower install ericam/susy --save | |||
| $ bower install susy --save | |||
There was a problem hiding this comment.
So is there any way to track versions?
There was a problem hiding this comment.
Yes, it saves the version number into bower.json
|
I approve of this, is there anything more to do here or can I merge it? |
|
merge it, i have reviewed and tested |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.